Fix #2574 #2657
Fix #2574 #2657
Conversation
There was a problem hiding this comment.
I've provided my reasoning behind the change. I would be happy to hear the opinions of @baronfel and @jeffhandley. I know Uri is a frequently used type and this could have been a bad decision.
| @@ -286,5 +286,17 @@ private static Dictionary<Type, TryConvertString> StringConverters | |||
| value = default; | |||
| return false; | |||
| }, | |||
|
|
|||
| [typeof(Uri)] = (string input, out object? value) => | |||
There was a problem hiding this comment.
I've removed this on purpose in #2127 in order to reduce the number of dependencies and reduce the size of a published NativeAOT app. IIRC it allows us to not include System.Private.Uri.dll for every published app.
There was a problem hiding this comment.
I think we should hold off on bringing this back because of the tradeoff. Echoing an offline discussion, I recommend that we lean into IParsable<T> and ISpanParsable<T> and even look ahead to extension interfaces as a better long-term approach for how we can handle more types without taking more hard dependencies like this in the short term.
|
In one program, I'm specifically parsing with UriKind.Relative. (It's a tool for replaying an HTTP request to a web API hosted in-process.) But I suppose this PR won't make that kind of use any harder, as I can just keep using a custom parser like now. |
This fixes #2574.